Re: multiline HTTP headers support in header()
| From: | Stas Malyshev | Date: | Thu, 03 Jul 2014 06:45:51 +0000 |
| Subject: | Re: multiline HTTP headers support in header() | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-75198@lists.php.net to get a copy of this message | ||
Hi!
> I'd tend to agree: if we're going to do this, let's just rip the
> band-aid off completely. I've got a quick and dirty patch at
>
> https://github.com/LawnGnome/php-src/compare/remove-multiline-headers?expand=1
> that does this, and applies cleanly against every branch from 5.4 to
> master.
This doesn't look correct - strpbrk will stop at nul bytes, but there's
no guarantee the actual SAPI would. Also no reason to delete so many
tests - some of them tests for other things than multiline headers too.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/