Re: Travis CI for pull requests

On Fri, Jul 11, 2014 at 9:22 AM, Tjerk Meesters <tjerk.meesters@gmail.com> wrote: > Hi guys, > > After making another commit into my ucwords() pr and waiting for an hour > or so I noticed that Travis CI hasn’t picked it up yet; in fact, the > previous commit wasn’t picked up either. > > Other pr’s that were created before or after mine were processed, though. > > Is this a known issue? It would be nice to have the added confidence of a > passing test suite before merging changes :) > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > Hi, https://travis-ci.org/php/php-src/requests tells me that 9074897bc6a5a3 <https://github.com/php/php-src/commit/bc6a5a3>-Added support for ranges like trim() hasPull requestbranch not included or excluded And while I was trying to figure out what does that mean, or why should that prevent the travis build, I've just remembered that we don't allow travis builds for PHP-5.3 and PHP-5.4 branches: http://git.php.net/?p=php-src.git;a=blob;f=.travis.yml;h=f1a333adcb3e6c35f3fe19c27fbd7a28d99fe7de;hb=refs/heads/PHP-5.4 So probably it is because of that. -- Ferenc Kovács @Tyr43l - http://tyrael.hu