Re: NetWare diff - 1.
| From: | Derick Rethans | Date: | Sun, 08 Feb 2004 19:33:30 +0000 |
| Subject: | Re: NetWare diff - 1. | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-7647@lists.php.net to get a copy of this message | ||
On Thu, 5 Feb 2004, Andi Gutmans wrote:
> Hi Ananth,
>
> I'm sorry but your patches are kind of messy. There are far too many #ifdef
> NETWARE's in there. It should be possible to improve on this by creating
> abstraction for things such as stat.
> I don't feel very comfortable with commiting them the way they are.
> Has anyone else here looked at them?
I just did, and found the same conclusion. Wouldn't it be much better to
maintain an off-site patch to it?
Derick