Re: [PATCH] Fixes for bugs #65463, #66036
| From: | Rasmus Lerdorf | Date: | Thu, 14 Aug 2014 22:18:44 +0000 |
| Subject: | Re: [PATCH] Fixes for bugs #65463, #66036 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-76527@lists.php.net to get a copy of this message | ||
On 08/14/2014 01:43 PM, Keyur Govande wrote:
> Hello,
>
> I've opened https://github.com/php/php-src/pull/770 for
> patches for bugs
> #65463, #66036. More details in the PR.
>
> The bug is reproducible on PHP 5.4, 5.5 and 5.6 with and without
> --enable-zend-signals.
>
> Please review, I'm hesitant to merge such a core change without more eyes.
The patch is simple enough and it has been running in production at Etsy
for quite a while now. But we have had shutdown order issues since
forever and I have lost track of all the various nuances of this
problem. As far as I can tell this doesn't cause any additional problems
and fixes an obvious and common segfault.
-Rasmus