Re: Kill ereg with fire

Hi Ferenc, On 31 Aug, 2014, at 7:00 pm, Ferenc Kovacs <tyra3l@gmail.com> wrote: > > > > On Sun, Aug 31, 2014 at 7:08 AM, Tjerk Meesters <tjerk.meesters@gmail.com> wrote: > Hi internals (again), > > Recently I’ve done a small assessment on how feasible it is to remove ext/ereg from the > project for the next major version. This is the result (so far): > > https://github.com/datibbaw/php-src/compare/kill-ereg > > I’ve replaced two instances of ereg with their pcre equivalents, OPcache and PGSQL. > > Btw, simply using ‘pcreposix.h’ didn’t work out for OPcache, I would get this error: > > Error Blacklist compilation: invalid argument to regex routine > > Perhaps I’ve missed something obvious, but porting it wasn’t hard either. > > Thoughts? > > Afair we have a patch floating around, but never made it into the repo, but everybody seemed to > agree to remove the core dependency of ereg and make it optional to enable. You mean make it optional to install via PECL, right? I agree ;-) Package maintainers can always choose to ship their php packages with ereg as a means to keep supporting it, regardless of how it’s provided (bundled or PECL). > > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu