Re: Optional nowait argument to sem_acquire
| From: | Matteo Beccati | Date: | Tue, 02 Sep 2014 14:01:04 +0000 |
| Subject: | Re: Optional nowait argument to sem_acquire | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-77038@lists.php.net to get a copy of this message | ||
Hi,
On 02/09/2014 15:38, guilhermeblanco@gmail.com wrote:
> I'd propose instead of accepting "nowait" only, I'd use a better support
> and accept "until", dealing with possible cases:
>
> * -1: Blocks and wait until lock is acquired
> * 0: Exactly what your patch does, attempt to grab and if it fails,
> just return false (I'd remove the E_WARNING)
(It doesn't. The warning is raised when the semaphore can't be acquired
for other reasons)
> * > 0: Acceptable time in milliseconds it would wait until consider
> the acquire failed
TBH, I don't know. semtimedop is not universally available (no BSD, as
far as I can tell) and I would prefer to avoid writing an alternative
implementation in case it's not available. On the other hand triggering
an error in such case wouldn't be nice.
Cheers
--
Matteo Beccati
Development & Consulting - http://www.beccati.com/