Re: Why does checkdnsrr() default to MX??

On 19 September 2014 02:58, Chris Wright <cw@daverandom.com> wrote: > On 18 September 2014 20:29, Kris Craig <kris.craig@gmail.com> wrote: >> Hey guys, >> >> I just spent some time troubleshooting what appeared to be a DNS issue >> before I realized that, absent the optional $type argument, checkdnsrr() >> defaults to "MX". Can anybody explain why it's defaulting to "MX" >> and not >> "ANY"? It seems really counter-intuitive. > > This is a big wtf, especially since getmxrr() exists. A cursory search > of github (not the best measure I know, but easy) reveals only a few > cases where this function is called without the second argument, and > every case I've found looks like they were expecting an A record, so > this code is likely broken anyway. > > In other words, +1 to change this to something saner ASAP. As an alternative, could we just make the type argument mandatory in PHP 7 and start issuing E_DEPRECATED warnings if it's omitted in 5.6 or 5.7? Adam