Request #67949 DOMNodeList should implement ArrayAccess
| From: | Florian Margaine | Date: | Sun, 21 Sep 2014 11:39:14 +0000 |
| Subject: | Request #67949 DOMNodeList should implement ArrayAccess | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-77413@lists.php.net to get a copy of this message | ||
Hi list,
The request is so that we can do this:
$html = <<<HTML
<div>data</div>
HTML;
$doc = new DOMDocument;
$doc->loadHTML($html);
var_dump($doc->getElementsByTagName('div')[0]->textContent);
I started implementing this on my branch (
https://github.com/Ralt/php-src/tree/issue-67949),
but then I was
thinking... ::offsetSet and ::offsetUnset don't really make sense in this
context.
From what I understand, SimpleXML does some magic to make it work without
implementing ArrayAccess.
I think it's cleaner to use ArrayAccess and to throw errors on ::offsetSet
and ::offsetUnset, but I'd like internals' opinion on this.
Regards,
*Florian Margaine*