Re: Internationalized Domain Name support in FILTER_VALIDATE_URL

On Wed, Sep 24, 2014 at 2:48 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > Hi! > >> I'll implement optional (and not default) support of IDN in filter_var(). >> >> Does anyone known if it's better to use libIDN (LGPL) or ICU (custom >> license deviated from the X license) from a license point of view? > > ICU is definitely better since we already have a lot of code using ICU > and AFAIK our current IDN functions (idn_to_*) use ICU. Which means it > would be advantageous to keep it in the single library - whatever bugs > there may be, at least the user will be dealing with one set of bugs > instead of two :) Indeed :) However I am not sure yet we should do it, or at least not by default. It may introduce side effects or BC issues.While IDN is bi-directional or could be called many times and returning the same result, we have to be careful to do not break things out there, for example someone relying on it to process URI/URL. Cheers, -- Pierre @pierrejoye | http://www.libgd.org