Re: [VOTE] Fix list() behavior inconsistency
| From: | Dmitry Stogov | Date: | Thu, 25 Sep 2014 11:15:59 +0000 |
| Subject: | Re: [VOTE] Fix list() behavior inconsistency | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-77627@lists.php.net to get a copy of this message | ||
disabling string handling would allow make operation simpler and would
improve regular access to array elements.
We won't need to check for (opline->extended_value & ZEND_FETCH_ADD_LOCK)
in FETCH_DIM_R handler.
However, it's going to be very small improvement, and I don't care a lot. :)
enabling string handling would require complication of
ZEND_FETCH_DIM_TMP_VAR handler (for strings support).
It's going to make list() handling a bit slower, but not significantly.
my choice +1 for disabling.
Thank. Dmitry.
On Thu, Sep 25, 2014 at 12:00 PM, Leigh <leight@gmail.com> wrote:
> On 25 September 2014 08:42, Dmitry Stogov <dmitry@zend.com> wrote:
> > Hi,
> >
> > The vote is opened at
> > https://wiki.php.net/rfc/fix_list_behavior_inconsistency
> >
> > Thanks. Dmitry.
>
> Since in the "should people be allowed to vote" thread, I said I think
> people should explain their votes, here is my explanation :)
>
> I am voting disable. +1 for consistency, but I think we already have a
> pretty rich suite of functions for working with strings that do not
> work with arrays, and vice versa. I think enabling list() to work on
> strings sets a precedent that more/all array handling mechanisms
> should be made to work with strings, and I'm not sure that's something
> we want.
>
> We've defined list as not working with strings in the manual, lets
> stick to our own definition.
>