Re: domxml memleak patches into PHP_4_3?

On Mon, 7 Apr 2003, Rasmus Lerdorf wrote: > I think this should go in. Like you said, for anything long-running, the > current domxml is almost useless, so I would consider this a bug fix. Yup, me too. Derick > > -Rasmus > > On 8 Apr 2003, Christian Stocker wrote: > > > Hi > > > > (Mainly) Rob Richards and (just a tiny little bit) me were hunting down > > some domxml memleaks (and Rob implemented DomDocument->free() method. > > Hooray ;) ). As we are rather late in the release process of PHP 4.3.2, > > I'm not sure, if it's wise to commit them now to the PHP_4_3 branch or > > if I should wait until after this release. > > > > Furthermore, the DomDocument->free() method was a much asked feature for > > domxml (and it really helps saving memory, if you want to process a lot > > of XML-Documents in one run). Would it be totally against the release > > rule if I add that function after 4.3.2 is released to the PHP_4_3 > > branch? > > > > Anyway, the diff file (against ext/domxml HEAD, not PHP_4_3 for the time > > being) can be found at > > http://trash.chregu.tv/domxml.memleak.diff, if > > anyone wants to use/test it right now > > > > chregu > > > > > > > > > > > > > > > > > -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------