Re: [RFC] GitHub Pull Requests Triage Team

On Fri, Oct 31, 2014 at 3:13 PM, Florian Anderiasch <ml@anderiasch.de> wrote: > On 31.10.2014 09:58, Peter Cowburn wrote:> On 30 October 2014 21:57, > John Bafford <jbafford@zort.net> wrote: > > > >> Hi, > >> > >> I would like to propose the creation of a team to triage the pull > requests > >> on GitHub, to help ensure that the pull requests are handled in a timely > >> manner. I am also volunteering to lead such a team, should the RFC be > >> approved. > >> > > > > Slightly off-topic, but how about the same thing for bugs.php.net and > > patches? > > This implies that on bugs and with PRs it's the same issue. > My cautious guess is that permissions to merge PRs on GitHub (which not > all developers can do) are not the main reason that stuff doesn't get > merged. > when qa.php.net is not dead, anybody with a php.net account is allowed to comment/close github PRs. for merging them, you are still required to have the appropriate karma to be able to push it to git.php.net. > Whereas on the bug tracker, afaik everyone with a php.net account can > triage, edit, assign, etc bugs. And still there are open ones. > I think that from the who can do what perspective those two are similar, anybody can help to review/debug and propose a improvements/solution or close the bogus reports/PRs, but at the end of the day, only those with approrpiate karma can merge the PR/patch for the fix. > > So, if it's only a permissions issue and people are active hindered to > get stuff done, go ahead and propose changes. If it just feels like > stuff doesn't get done... maybe no one's around to do it. > > personally I think that we lack people for both triaging/reviewing and merging/pushing the changes. So anybody willing to look into bugs/PRs are more than welcome, and even if he/she don't have the knowledge or karma to fix/merge the issue, it will already make it easier for those who do to do the last step. ps: if you need help for getting something looked at, org merged, feel free to ping the RMs and/or complain on internals@, because it is easy for us to miss things because of the already huge backlog of open bugs/PRs. I personally think that we should make some drastic measures to bring down the open bugs/feature requests to a managable level (see http://www.joelonsoftware.com/items/2012/07/09.html) as currently we have all the bugs/features reported since 1999. -- Ferenc Kovács @Tyr43l - http://tyrael.hu