Re: Better RFC conformance for FILTER_VALIDATE_URL
| From: | Kévin Dunglas | Date: | Wed, 05 Nov 2014 21:57:02 +0000 |
| Subject: | Re: Better RFC conformance for FILTER_VALIDATE_URL | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-78750@lists.php.net to get a copy of this message | ||
Hi,
According to the discussion on GitHub, I've made some changes on this PR:
- Added a new FILTER_VALIDATE_DOMAIN filter validating domain names
- Added a FILTER_FLAG_HOSTNAME flag to allow checking hostnames (_ are
forbidden in hostname but not in domains)
- Changed FILTER_VALIDATE_URL to use this new validator
When https://github.com/php/php-src/pull/890
will be merged, it will be
easy to add IDN support to this new domain validator.
2014-10-14 13:48 GMT+02:00 Daniel Ribeiro <drgomesp@gmail.com>:
>
> Nice work man, it looks really good.
>
>
> Daniel Ribeiro
> http://danielribeiro.org
>
> On Tue, Oct 14, 2014 at 3:41 PM, Kévin Dunglas <dunglas@gmail.com> wrote:
>>
>> Hi,
>>
>> I opened a PR making FILTER_VALIDATE_URL more strict and more compliant
>> with standards: https://github.com/php/php-src/pull/826
>>
>> Can anyone review (and merge) this patch?
>>
>> Thanks!
>> --
>> Kévin Dunglas
>> Consultant et développeur freelance
>>
>> http://dunglas.fr
>> Tél. : 06 60 91 20 20
>
>
--
Kévin Dunglas
Consultant et développeur freelance
http://dunglas.fr
Tél. : 06 60 91 20 20