Re: Re: About bug #26753 and zend_register_list_destructors()

On Mon, 16 Feb 2004, Andi Gutmans wrote: >It seems to me that the difference is in the dtor() callback's parameters. >I'm not sure why type_name is not passed to >zend_register_list_destructors(). It probably did not exist when it was >originally written. Zeev might know? :) >I guess we can either fix the comparison, change >zend_register_list_destructors() to accept type_name, or nuke >zend_register_list_destructors() completely and move to _ex(). >Probably the last is the best option if we only have to fix two extensions. Wouldn't it be best to fix the comparison in PHP 4 and 5 and nuke the function in PHP 5? This would let possible 3rd party extensions use the old macro, but not cause any crashes with the zend_fetch_list_dtor_id() calls.. And change the extensions that use the register_list_destructors() macro to use the _ex() function. --Jani >At 11:18 PM 2/15/2004 +0200, Jani Taskinen wrote: > >> This is either bug in zend_fetch_list_dtor_id() as said in the >> bug report or misuse of [zend_]register_list_destructors(). >> >> So which one is it? Is zend_register_list_destructors() deprecated in >> favor of zend_register_list_destructors_ex() or what?? >> >> FYI: register_list_destructors() is only used by ext/mssql in HEAD. >> It's also used by ext/crack in PHP_4_3. But not anywhere else. >>