SAPI refactoring
| From: | Florian Margaine | Date: | Sat, 15 Nov 2014 10:16:11 +0000 |
| Subject: | SAPI refactoring | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-78916@lists.php.net to get a copy of this message | ||
Hi list,
As of today, most of the SAPIs have a lot of code duplication with
regards to HTTP headers parsing/handling.
I'm about to completely duplicate a function from one SAPI to the
other to add a feature to fpm (
getallheaders(), see
https://github.com/php/php-src/pull/523), and
I'd like to avoid that.
Should I create a sapi/main/ folder for common functions across the
SAPIs? Or should each SAPI remain completely independent from each
other, even if it means duplicating code?
Regards,
--
Florian Margaine