Re: EX(scope) removing
| From: | Dmitry Stogov | Date: | Thu, 27 Nov 2014 19:42:40 +0000 |
| Subject: | Re: EX(scope) removing | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79245@lists.php.net to get a copy of this message | ||
Thanks. Probably, I'll commit it tomorrow.
Dmitry.
On Thu, Nov 27, 2014 at 9:09 PM, Matteo Beccati <php@beccati.com> wrote:
> Hi Dmitry,
>
> On 27/11/2014 18:27, Dmitry Stogov wrote:
>
>> Could you please take a look into the patch that removes EX(scope)
>> https://gist.github.com/dstogov/5ad50d582346385d587e
>>
>> All phpt tests are passed, but I'm not completely sure about one line -
>> https://gist.github.com/dstogov/5ad50d582346385d587e#
>> file-ex_scope-05-diff-L193
>>
>> On the other hand I can't imagine what it may break.
>>
>> Matteo, can you please run your test suites with this patch.
>>
>
> Done. No regressions found for:
>
> * run-tests
> * Revive Adserver + MySQL & Postgres
> * PHPUnit
> * phpspec
> * Doctrine2 + SQLite & Postgres
>
>
> Cheers
> --
> Matteo Beccati
>
> Development & Consulting - http://www.beccati.com/
>