Re: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file

Ignore this, already fixed by Stas... didn't notice. http://git.php.net/?p=php-src.git;a=commitdiff;h=b75867fff0d141bf2f81646dd5fae991e85b26ca Kaplan On Wed, Dec 17, 2014 at 4:05 PM, Lior Kaplan <lior.k@zend.com> wrote: > > Hi, > > Can someone please do this minor change in the PHP 5.4 tests ? > > Kaplan > > On Wed, Dec 3, 2014 at 6:08 PM, Lior Kaplan <lior.k@zend.com> wrote: >> >> Hi Stas, >> >> I don't have permissions to fix this myself as the 5.4 branch is closed >> for security only. >> >> You've added ext/curl/tests/bug68089.phpt which includes skipif.inc in >> the same directory. >> >> Could you either copy the file from 5.5 branch or put its contents >> instead of the include ? >> >> >> $ git show PHP-5.5:ext/curl/tests/skipif.inc >> <?php >> if (!extension_loaded("curl")) exit("skip curl extension not >> loaded"); >> if(false === getenv('PHP_CURL_HTTP_REMOTE_SERVER')) { >> if (php_sapi_name() != "cli") { >> die("skip PHP_CURL_HTTP_REMOTE_SERVER env variable is not >> defined"); >> } >> >> >> Thanks, >> >> Kaplan >> >> >> ---------- Forwarded message ---------- >> From: Eyal Teutsch <eyal.t@zend.com> >> Date: Thu, Oct 30, 2014 at 9:21 AM >> Subject: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file >> To: Lior Kaplan <lior.k@zend.com> >> Cc: Gadi Goldbarg <gadi@zend.com> >> >> >> Kaplan, >> >> We noticed here that the 5.4.34 branch 9 >> >> https://github.com/php/php-src/tree/PHP-5.4.34/ext/curl/tests) >> misses >> the skipif.inc file which is required by some of the tests, and which >> exists in the master ( >> https://github.com/php/php-src/tree/master/ext/curl/tests) >> . >> >> As our PHP ambassador, could you please fix that? >> >> thx >> T >> >>