Re: Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt
tests/output/ob_start_error_005.phpt
| From: | Stanislav Malyshev | Date: | Mon, 29 Dec 2014 10:22:03 +0000 |
| Subject: | Re: Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt |
||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79994@lists.php.net to get a copy of this message | ||
Hi!
> Hi Stas
>
> 2014-12-29 9:05 GMT+01:00 Stas Malyshev <smalyshev@gmail.com>:
>> The CI tests still seem to be failing:
>>
>> =====================================================================
>> FAILED TEST SUMMARY
>> ---------------------------------------------------------------------
>> SPL: spl_autoload() and friends [ext/spl/tests/spl_autoload_001.phpt]
>> SPL: spl_autoload() with methods [ext/spl/tests/spl_autoload_005.phpt]
>> SPL: spl_autoload() with inaccessible methods
>> [ext/spl/tests/spl_autoload_007.phpt]
>> SPL: spl_autoload() with exceptions [ext/spl/tests/spl_autoload_008.phpt]
>> =====================================================================
>>
>> Please take a look.
>
> I looked at the tests and:
>
> * spl_autoload_001.phpt fails with an E_RECOVERABLE_ERROR but that is
> not due to my patch (tests with and without)
> * spl_autoload_005.phpt fails due to an E_STRICT (non-static method
> called statically)
> * spl_autoload_007.phpt fails due to same reason as
> spl_autpload_001.phpt it seems
> * spl_autoload_008.phpt fails due to an E_STRICT like spl_autoload_005.phpt
You are right, looks like this is caused by
https://github.com/php/php-src/commit/ad728725cb8e899a8415aa81db48825fac25e0d5
Levi, could you please take a look and fix it?
--
Stas Malyshev
smalyshev@gmail.com