Preventing users from voting multiple times on a single bug
| From: | Jacob Bednarz | Date: | Wed, 31 Dec 2014 11:12:10 +0000 |
| Subject: | Preventing users from voting multiple times on a single bug | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-80023@lists.php.net to get a copy of this message | ||
Hi,
This is my attempt at a patch for a bug related to users being able to vote multiple times on the same bug (full report is at https://bugs.php.net/bug.php?id=51535). While this isn't a huge change I wanted to get confirmation on a few things before I went ahead so that I didn't break anything too badly.
1. Is this the correct list for changes related to bugs.php.net itself? If
not, what is the correct mailing list for this change?
2. I see php-src has a defined coding standard however I wasn't able
to see one for bugs.php.net so I have just gone with the standards that
were already present near my changes. If there is a defined
standards guideline which I have missed, feel free to direct me that
way and I will check for any violations within my changes before this
is merged.
3. Hannes was nice enough to give me some direction around getting my
changes reviewed however with code changes is the preferred option to
get review and merge it yourself? Or is there a release cycle? Or how
does that aspect work?
I've attached the patch and opened a pull request via GitHub (https://github.com/php/web-bugs/pull/13) for anyone that would like to review this one for me.
Thanks again,
Jacob.