resource consistency

From: Date: Wed, 31 Dec 2014 22:21:36 +0000
Subject: resource consistency
Groups: php.internals 
Request: Send a blank email to internals+get-80033@lists.php.net to get a copy of this message
Hi, related to bug #43525, I see that zend_fetch_resource() still expects a default id as int as parameter. After some investigation i think that the "int default_id" argument can be surely dropped from the signature. The only extension in the core passing it is ext/interbase, all the others pass -1. Any other zend_list_* signature expects no integer but a zend_resource*. What I would do instead - transfer the control over the defauld_id to the corresponding extension. Maybe also making a helper function in zend_list.c, if it proves itself as needed. But in any case, to be consistent, the consistency should be that the api only works with zend_resource *. Please thoughts, I'd be inventing a patch if it's found sensible. Regards Anatol

« previous php.internals (#80033) next »