Question about patch for bug 61285 - SSL connections do not timeout
| From: | Brad Broerman | Date: | Fri, 02 Jan 2015 15:46:34 +0000 |
| Subject: | Question about patch for bug 61285 - SSL connections do not timeout | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-80098@lists.php.net to get a copy of this message | ||
Hi,
I have a pull request for issue 61285 - SSL connections do not
timeout, and have a question about it's status
I created a pull request for this years ago, back in PHP 5.5.20 and
it was never merged into the master. I recently updated my clone of the
repo to the latest and re-wrote my patch against the newly updated
master and re-created the pull request.
Is there a possibility of this being pulled? If not, why? I have
tested this code both in the original 5.5.20, in the new 5.6.4, and
briefly with master. I believe it works pretty well. In the pull
request itself, I added a comment about the travis ci build failing, but
I don't see where the failure has anything to do with this extension.
Would this block acceptance of this patch?
Thanks
Brad Broerman