RE: [PHP-DEV] [RFC] Add is_cacheable() stream-wrapper operation
| From: | François Laupretre | Date: | Sun, 04 Jan 2015 13:43:32 +0000 |
| Subject: | RE: [PHP-DEV] [RFC] Add is_cacheable() stream-wrapper operation | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80150@lists.php.net to get a copy of this message | ||
> De : Pierre Joye [mailto:pierre.php@gmail.com]
> Could you add tests please? A must before going any further :)
Three tests are included in the patch : one to check that phar uris are cacheable, one to check that
plain files and 'file:' uris are cacheable, one to check that 'http' and
'https' uris are not cacheable.
An additional test should be added in the opcache tests dir to check that opcache is caching plain
files, phar uris, but not other protocols. It is in my todo list, but I wanted your comments first,
as it is more complex to implement.
> Please add the changes to UPGRADING.INTERNALS and UPGRADING as well.
Done
Regards
François