Re: Cleaning up dangling whitespace
| From: | Andrea Faulds | Date: | Mon, 05 Jan 2015 23:25:07 +0000 |
| Subject: | Re: Cleaning up dangling whitespace | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80213@lists.php.net to get a copy of this message | ||
Hey Stas,
> On 5 Jan 2015, at 22:58, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean it up (it's easy to do automatically) in master, but this produces
> a big patch that may also create some conflicts with existing pull reqs
> (easily resolved, but still).
> So, I'd like to ask if there are any objections to such cleanup? If not,
> then I'll do it, probably next weekend.
I expect you’ll cause me considerable pain when I have to merge that into the bigints branch. But
it’s for the best. I’m actually pretty guilty of whitespace changes myself, so I probably
deserve that pain.
No objections. :)
--
Andrea Faulds
http://ajf.me/