Re: [PATCH] Fixed bug #68839 Possible null pointer dereference
| From: | Joshua Rogers | Date: | Thu, 15 Jan 2015 16:48:29 +0000 |
| Subject: | Re: [PATCH] Fixed bug #68839 Possible null pointer dereference | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80569@lists.php.net to get a copy of this message | ||
Hi,
On 16/01/15 03:41, Michael Wallner wrote:
> Looks good.
There's another one(2) in /ext/phar/util.c:
--snip--
911 if (error) {
912 *error = NULL;
913 }
914 /* seek to start of internal file and read it */
915 if (FAILURE == phar_open_entry_fp(entry, error, 1)) {
916 return NULL;
917 }
918 if (-1 == phar_seek_efp(entry, 0, SEEK_SET, 0, 1)) {
919 spprintf(error, 4096, "phar error: cannot seek to start of file
\"%s\" in phar \"%s\"", entry->filename, phar->fname);
920 return NULL;
921 }
--snip--
Should the patch, perhaps be inside the spprintf() function?
That would take care of future problems, too.
Thoughts?
Thanks,
--
-- Joshua Rogers <https://internot.info/>
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc