Re: Re: com php-src: Faster sorting algo: UPGRADING Zend/Makefile.am Zend/tests/methods-on-non-objects-usort.phpt Zend/zend_API.c Zend/zend_hash.c
Zend/zend_hash.h Zend/zend_ini.c Zend/zend_llist.c Zend/zend_qsort.c Zend/zend_qsort.h Zend/zend_sort.c Zend/zend_sort.h Zend/zend_ts_hash.c
Zend/zend_types.h configure.in ext/ereg/ereg.c ext/intl/collator/collator_sort.c ext/phar/dirstream.c ext/phar/phar_internal.h ext/standard/array.c
ext/standard/info.c ex
| From: | Xinchen Hui | Date: | Sat, 17 Jan 2015 04:03:33 +0000 |
| Subject: | Re: Re: com php-src: Faster sorting algo: UPGRADING Zend/Makefile.am Zend/tests/methods-on-non-objects-usort.phpt Zend/zend_API.c Zend/zend_hash.c Zend/zend_hash.h Zend/zend_ini.c Zend/zend_llist.c Zend/zend_qsort.c Zend/zend_qsort.h Zend/zend_sort.c Zend/zend_sort.h Zend/zend_ts_hash.c Zend/zend_types.h configure.in ext/ereg/ereg.c ext/intl/collator/collator_sort.c ext/phar/dirstream.c ext/phar/phar_internal.h ext/standard/array.c ext/standard/info.c ex |
||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80675@lists.php.net to get a copy of this message | ||
Hey:
On Sat, Jan 17, 2015 at 11:54 AM, Stanislav Malyshev
<smalyshev@gmail.com> wrote:
> Hi!
>
>> you could fix it by change the output(it must because equal elements compare)...
>
> I could but I'd be busy for this weekend so it'd be better if you fixed
> it since your patch broke it :)
okey, I just don't have a env to reproduce it..
> Also it would be nice if such big changes were run through the CI before
> committing. We have it run automatically with pull requests and also if
> you don't want to do a pull you can connect Travis to your own fork so
> that it would run the tests once you push it to your branch.
thanks, this is really helpful.
>
> Having CI in the red for a long time is not good since it allows other
> bugs to creep in and prevents proper evaluation of pulls. In fact, we
> have RFC about that: https://wiki.php.net/rfc/travis_ci
>
> --
> Stas Malyshev
> smalyshev@gmail.com
--
Xinchen Hui
@Laruence
http://www.laruence.com/