Re: [PATCH 2/3] Fix null pointer dereference

Hey: On Thu, Jan 22, 2015 at 2:27 AM, Joshua Rogers <git@internot.info> wrote: > --- > > These issues are not serious(only triggerable by the runner/caller of the PHP program), so no > need to make them private. > > sapi/litespeed/lsapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sapi/litespeed/lsapi_main.c b/sapi/litespeed/lsapi_main.c > index 2b2385c..d767306 100644 > --- a/sapi/litespeed/lsapi_main.c > +++ b/sapi/litespeed/lsapi_main.c > @@ -487,7 +487,7 @@ static int lsapi_chdir_primary_script( zend_file_handle * file_handle ) > getcwd( s_cur_chdir, sizeof( s_cur_chdir ) ); > > p = strrchr( file_handle->filename, '/' ); > - if ( *p ) > + if ( p ) > { > *p = 0; > if ( strcmp( file_handle->filename, s_cur_chdir ) != 0 ) { > -- > 1.9.1 > thanks for the recently great reporting.. myabe, you could send these patch via bugs.php.net, or github PR? it's better than mails :) thanks > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/