Re: [VOTE] RFC: Introduce session_start() options - read_only, unsafe_lock, lazy_write and lazy_destroy

Hi all, On Sun, Mar 16, 2014 at 3:11 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > Modified patch for this RFC is here > > > https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-session-lock > > There may be leftover still. I'll check it again later, but it's > appreciated if you find any. > > Someone asked if I'm going to allow to change all of session INIs by > session_start(), > I think it's good to have. > > I would like to implement this as hash of INI options and handlers like > > "option_name" => function_of_INI_modify_handler; > > This way, I can iterate parameter array easily/efficiently, can change INI > values > easily/efficiently and raise appropriate errors. > > Any comments for this? > Sorry that the patch didn't included in PHP 5.6. I've made patch for master since PHP 5.6 is released already. https://wiki.php.net/rfc/session-lock-ini https://github.com/php/php-src/pull/1016 Except comments, changes are almost minimal, but includes a few bug fixes that tests equality of PS(session_status) against "php_session_none". The comparison must be "PS(session_status) != php_session_active" as it has php_session_disabled. I also removed 2 needless session globals. Comments are appreciated. This patch boosts PHP application performance a lot when session data have not changed. It's faster than benchmark in the wiki because hashing has removed. If I don't any comment in a few days, I'll merge it to master. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net