Re: ZEND_APIifying zendparse()

On Thu, Jan 22, 2015 at 11:00 AM, Nikita Popov <nikita.ppv@gmail.com> wrote: > On Thu, Jan 22, 2015 at 10:28 AM, Sara Golemon <pollita@php.net> wrote: > >> http://github.com/sgolemon/astkit (See the README.md) >> >> I'm using zendparse() to generate an AST but *not* compile it to >> bytecode. In order to get this extension building, I have to patch >> php-src to export the zendparse symbol. Anyone object to me pushing >> that change? >> >> diff --git a/Zend/zend_globals_macros.h b/Zend/zend_globals_macros.h >> index b8fb763..190905f 100644 >> --- a/Zend/zend_globals_macros.h >> +++ b/Zend/zend_globals_macros.h >> @@ -36,7 +36,7 @@ BEGIN_EXTERN_C() >> # define CG(v) (compiler_globals.v) >> extern ZEND_API struct _zend_compiler_globals compiler_globals; >> #endif >> -int zendparse(void); >> +ZEND_API int zendparse(void); >> >> >> /* Executor */ >> > > Looks reasonable :) Indeed. Add a note in UPGRADING.INTERNALS while being at it pls :) -- Pierre @pierrejoye | http://www.libgd.org