Re: Removing base class from session handler
| From: | Yasuo Ohgaki | Date: | Sat, 24 Jan 2015 02:14:34 +0000 |
| Subject: | Re: Removing base class from session handler | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-81064@lists.php.net to get a copy of this message | ||
Hi Stas,
On Sat, Jan 24, 2015 at 9:29 AM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:
> > Let's keep SessionHandler class. However,
> > PHP_FUNCTION(session_set_save_handler)
> > should be cleaned up to verify implemented/extended interface/class.
> > It's BC.
> > Do you have opinion for this?
>
> I think it would be OK to require implementing the interface (and of
> course the class should be implementing that as well). That sounds to me
> like a kind of BC break that is acceptable in PHP 7. Probably requires
> an RFC though as it is a BC break - and maybe there are reasons why it
> wasn't done that I was missing, then they will be exposed when
> discussing the RFC.
I don't remember well the reason why neither. I guess the reason why
session_set_save_handler()
does not check class/interface definition as usual is for PHP4
compatibility. It's legacy code anyway.
I'll write the RFC as soon as other proposal discussion finishes.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net