Re: [RFC] Enable error_handler callback parameters to be passed by reference

Hi, the idea behind the rfc is not to change error messages, it's only to append useful information to them. Changing lines/filenames is surely something controversial and might be only useful when compiling configuration files or templates to php code. Therefore we have 3 options in the voting section. > Maybe better access to logging system for custom logging would be more > efficient instead? The logging system can be accessed with 1 line of code (trigger_error, throw new exception, etc), so from userland perspective I don't see any deficits here. In case someone needs multiple error handlers, it might be necessary to implement sth. like spl_set_error_handler (similar to spl_autoload_register), but that's not in the scope of this rfc. Regards Thomas Stanislav Malyshev wrote on 27.01.2015 20:43: > Hi! > >> I feel it's kindof wrong direction. >> >> if you want custom logs, maybe you should use custom logger. > > Same here, API basing on modifying something that is supposed to be > internal engine things feels wrong, even if it does work. Changing error > message is borderline, changing things like lines/filenames just feels > wrong. > > Maybe better access to logging system for custom logging would be more > efficient instead? > > -- > Stas Malyshev > smalyshev@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >