Re: [PATCH] Allow constant expressions

From: Date: Thu, 10 Apr 2003 08:21:55 +0000
Subject: Re: [PATCH] Allow constant expressions
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to internals+get-833@lists.php.net to get a copy of this message
On Thu, 2003-04-10 at 02:59, Zeev Suraski wrote: > I think there's one broken thing in this patch (I haven't tested it, so I > could be wrong) - it removes some functionality that we did have in the > past. static_scalar can no longer contain a constant (one that was defined > with define()). That means that constant initializers for arrays, default > arguments, etc - lose a big chunk of functionality. (again, I arrived at > that conclusion by briefly going over the parser patch, if you took this > into account and it does work - go ahead and commit it, it looks good). > It does,kinda. Because I was doing folding the last patch adds a new type (const_sclar i believe, i'm becoming senile), which doesn't support define'd constants, etc. Normal functionality remains untouched. I personally think that's a reasonable 90%, and its nice to also have a compile time constant. -Sterling -- "C makes it easy to shoot yourself in the foot; C++ makes it harder, but when you do, it blows away your whole leg." - Bjarne Stroustrup

« previous php.internals (#833) next »