Re: Coercive Scalar Type Hints RFC - BC breaks
| From: | Yasuo Ohgaki | Date: | Tue, 24 Feb 2015 04:32:25 +0000 |
| Subject: | Re: Coercive Scalar Type Hints RFC - BC breaks | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-83628@lists.php.net to get a copy of this message | ||
Hi Francois,
On Tue, Feb 24, 2015 at 1:17 PM, François Laupretre <francois@php.net>
wrote:
> I ran the PHP core 'make test' on a basic configuration, still running a
> significant number of 8785 tests.
>
> Note: the restrictions on numeric string conversions (leading
> chars/zeroes, trailing chars) are not simulated yet, but they shouldn't
> change the results very much.
>
> The ruleset corresponding to the coercive RFC, as it is published today,
> globally broke 7.3% of tests. From these 7.3%, 5.3% correspond to the
> disabled conversions from null to scalar types, which will probably have to
> be reintroduced, as it was suspected. So, if we consider that these
> conversions are re-enabled, the resulting coercive ruleset breaks 1.9% of
> the tests, which is rather positive, IMO, because there is still room for
> improvements.
>
> More details soon.
>
I'm guessing most failures are due to E_DEPRECATED.
I suggest to test without E_DEPRECATED, then it would
be fair figure for the patch. Could you run test without
E_DEPRECATED? We can use -c option for almost all
tests, I think.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net