Re: Feature request and RFC

2015-02-24 17:36 GMT+01:00 Benjamin Eberlei <kontakt@beberlei.de>: > Hi, > > On Tue, Feb 24, 2015 at 5:17 PM, Thomas Gielfeldt <thomas@gielfeldt.dk> > wrote: > >> Hi internals. >> >> I've made PR proposing a feature request: A new interface Sortable. >> >> https://github.com/php/php-src/pull/1116 >> >> If possible, I would like to create and RFC describing this in more >> detail, >> and perhaps get a voting on. >> > > so you need to implement all methods? This can probably be considered a > violation of the Interface Segregation Principle. But adding an interface > for each method seems a bit much as well. > I've made another PR to show a different implementation. I've also registered a wiki account. I don't have access to create an RFC for this. I'm not actually sure how to go about this? https://github.com/php/php-src/pull/1123 >> Thanks >> >> Br, >> >> Thomas Gielfeldt >> > >