Re: Coercive STH - some real world tests and updated RFC
| From: | Damien Tournoud | Date: | Fri, 27 Feb 2015 13:37:50 +0000 |
| Subject: | Re: Coercive STH - some real world tests and updated RFC | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-84000@lists.php.net to get a copy of this message | ||
Hi Zeev,
On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski <zeev@zend.com> wrote:
> Drupal homepage: One new E_DEPRECATED warning, which seems to catch a
> real bug, or at least faulty looking code:
> $path = trim($path, '/'); // raises E_DEPRECATED, as $path is boolean
> false.
> return $path;
>
> Drupal admin interface (across the all pages): One new E_DEPRECATED
> warning, which again seems to catch a real bug - stripslsahes() operating
> on a boolean.
>
All those are due to a bug in substr(), that we see now only thanks to
proper type identification. There is no reason for substr() to ever return
a boolean. It really needs to be fix to always return a string.
Damien