odbc extension build issues (shared vs. standalone)

Hi, Following Remi's revert of my commit [1] I'd like to suggest a better solution for master which would be introducing --enable-odbc and having the ODBC drivers default to no (similar to DBA). Current problem is fixing build as a standalone (phpize...) breaks support with builds as "./configure ... -with-unixODBC=shared,/usr" For 5.5/5.6 - I'm not sure whether to play with parsing the options to handle "shared" or "shared,[path]" (see example bellow) or just leave the issue to reduce noise for now (we have this for years), although we already did some changes about --with-odbcver . Any thoughts / ideas / objections ? Kaplan p.s. Before playing with these options I'd like to also turn ODBC builds on travis... --- diff --git a/ext/odbc/config.m4 b/ext/odbc/config.m4 index 4caf567..7a1c98e 100644 --- a/ext/odbc/config.m4 +++ b/ext/odbc/config.m4 @@ -452,8 +452,10 @@ PHP_ARG_WITH(unixODBC,, AC_MSG_CHECKING(for unixODBC support) if test "$PHP_UNIXODBC" != "no"; then - if test "$PHP_UNIXODBC" = "yes"; then + if test "$PHP_UNIXODBC" = "yes" || test "$PHP_UNIXODBC" = "shared"; then PHP_UNIXODBC=/usr/local + else + PHP_UNIXODBC=echo "$PHP_UNIXODBC"|$SED 's/^shared,//' fi ODBC_INCDIR=$PHP_UNIXODBC/include ODBC_LIBDIR=$PHP_UNIXODBC/$PHP_LIBDIR --- [1] http://git.php.net/?p=php-src.git;a=commitdiff;h=1174b399ad325b630ba202abc6671d8055160b99