Re: [RFC][VOTE] Constructor behaviour of internal classes
| From: | Nikita Popov | Date: | Tue, 31 Mar 2015 20:07:15 +0000 |
| Subject: | Re: [RFC][VOTE] Constructor behaviour of internal classes | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-85603@lists.php.net to get a copy of this message | ||
On Mon, Mar 30, 2015 at 6:06 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Dan,
>
> The updated patch is at
> https://github.com/php/php-src/pull/1205
>
> The main difference is in ext/intl.
> If you don't see any problems I can commit it.
>
> I didn't think about the classes you missed.
>
> Thanks. Dmitry.
>
I'm wondering, if we implement throwing zpp by using EH_THROW mode, which
relies on converting warnings to exceptions, does that mean that the same
code using strict_types=1 mode will start throwing TypeException instead of
whatever exception type is passed to replace_error_handling? If so, that
would be pretty weird. Maybe we should just always throw TypeException for
this? Could also add a zpp flag for doing that as all the code for throwing
TypeExceptions is already present, we just need to trigger it.
Nikita