Re: Deprecating ldap_sort

Zitat von Andreas Heigl <andreas@heigl.org>:

Hi Anatol. Côme already replied to the technical aspects of what we are trying to do. Am 25.06.15 um 17:56 schrieb Anatol Belski:

Hi Andreas,

-----Original Message----- From: Andreas Heigl [mailto:andreas@heigl.org] Sent: Wednesday, June 24, 2015 5:40 PM To: internals@lists.php.net Cc: Côme BERNIGAUD Subject: [PHP-DEV] Deprecating ldap_sort Hi everyone. Côme Bernigaud and myself are currently cleaning up the LDAP-Extension (Well, Côme is doing the hard work and I'm trying to assist in some way). We would like to bring it in line with a more recent version of the OpenLDAP-lib. Currently the plan is to require OpenLDAP 2.4 as the minimum version to build ext/ldap against. This is on a very good way [1]. But in said OpenLDAP-library the ldap_sort-function already has been marked as deprecated [2]. Therefore we'd like to at least mark PHPs ldap_sort function as deprecated also. The current rewrite will make it possible to later use the server-sided sort functionality so there will be only limited need for the current (client sided) ldap_sort function. As it's a BC-break to remove the ldap_sort function will we have to setup an RFC for that? Or is it a plain "mark it deprecated in PHP7 and throw it away in PHP8" kind of decission? And will it be possible to get that marked deprecated in 7 at all?

I've a few questions to this. Can it be implemented with non deprecated symbols? Or maybe, can the server side sort not be done with the same function, as it's probably the same job? Or it will be really not required? Any info about the plans on the openldap side to remove the deprecated symbols (AFAIR those are kept already for years)? We're currently don't know, how wide this function is used and how much it would break. In general, deprecating it if there's a strong reason, could be sufficient. If there's a small possibility to keep this function, we should use it. Fe maybe it could kept and enabled with a configure option, that way it'll be still usable.

I might have not expressed myself correctly about the deprecated thingy. I was actually refering to whether it would be possible to raise an E_DEPRECATED for calling ldap_sort. If we could bring that into PHP7.0 we would be able to remove it from PHP7.1 and get a clean codebase without any functions marked as deprecated in the underlying lib. If we'd have to wait for PHP7.1 for the E_DEPRECATED that would mean we can remove the deprecated function_calls at the earliest in PHP7.2. That's a long timescale ;)

Any feedback from the ldap users were appreciated here, as well.

I don't use it ;) I've checked phpLdapAdmin (not used), GOsa (not used) and Zend\Ldap (sadly used, but I can rewrite that part) but that are just three libs out there out of so many self-written scripts....

FWIW Net_LDAP and its successors Net_LDAP2 and Horde_Ldap don't use ldap_sort anymore since 2006 either. -- Jan Schneider The Horde Project http://www.horde.org/ https://www.facebook.com/hordeproject