Re: NAN/INF->int conversion in 5.6

From: Date: Sun, 28 Jun 2015 09:58:46 +0000
Subject: Re: NAN/INF->int conversion in 5.6
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-86923@lists.php.net to get a copy of this message
On 28.06.2015 02:46, Stanislav Malyshev wrote: > My question is: should we backport code from PHP 7 that checks for > infinity/nan and put it into 5.6? Or it's not worth it and it's ok for > 5.6 to return random weird stuff there? (I know it's not exactly random > and there's a reason why it's that number but it looks that way). While I can't imagine many people would stumble over this (as apparently there was no bug report) it could be a tricky one if you're not extra paranoid when working with INF, I don't think it's worth changing this behaviour so long after 5.6.0 was released. Good that it's fixed in 7 though. It should absolutely be documented (and I still can't fathom why searching for INF on the website only gives me function results and not a direct hit for a 1:1 match on a pre-defined constant in core, but let's not start this discussion.) Greetings, Florian

« previous php.internals (#86923) next »