Re: PHP7 releases vs Windows Sources?

Christoph Becker wrote: > Nikita Popov wrote: > >> On Wed, Jun 17, 2015 at 12:20 AM, Christoph Becker <cmbecker69@gmx.de> >> wrote: >> >>> Johannes Schlüter wrote: >>> >>>> On Tue, 2015-06-16 at 02:02 +0200, Christoph Becker wrote: >>>> >>>>> Fair enough. However, the Windows sources neither contain the generated >>>>> parser files, because they would break linking on Windows, see >>>>> >>>>> <http://news.php.net/php.internals/86685>. >>>> >>>> This is a bug and has to be addressed. >>> >>> I have investigated further. The issue is commit b8e2629[1]. I'm >>> certain that Sara had good reasons to mark zendparse() as ZEND_API. >>> However, that breaks building with the generated zend_language_parser >>> files with MSVC, if they have been generated with a somewhat recent >>> bison (2.4.1 still works, 2.7.12 fails), because newer versions declare >>> zendparse() again in .c and .h – without ZEND_API. >>> >>> [1] >>> < >>> >>> https://github.com/php/php-src/commit/b8e262901e56a4d9a6664d348c9878246579239e >> >> We need some ZEND_API way to invoke the parser from extensions. If it's >> inconvenient to have on zendparse() directly because bison, I'd suggest >> dropping it there and creating a ZEND_API wrapping function. > > Thanks! That would be a simple and clean solution. I'll make a > respective PR if no one beats me to it. Thanks to Anatol this issue has been solved by tweaking makedist: <http://git.php.net/?p=php-src.git;a=commit;h=b81188518bc6018ad784492720558affeec7abf6> -- Christoph M. Becker