Re: Revisit trailing commas in function call parameters?

Some more context: https://bugs.php.net/bug.php?id=64176 <https://bugs.php.net/bug.php?id=64176> https://wiki.php.net/rfc/trailing-comma-function-args <https://wiki.php.net/rfc/trailing-comma-function-args> (failed 15-20) On a more positive side, this change was very well received within Facebook when implemented within HHVM; this was a mix of: - the ‘git blame’ advantage is much bigger than we expected; this is probably true for any large project that has many contributors to the same file. It doesn’t help much if each file basically has an ‘owner’. - people new to PHP liked not having to remember where they are allowed and when they’re not. This felt like removing one small inconsistency without much of a downside > On Jun 28, 2015, at 7:19 AM, Jakub Kubíček <kelerest123@gmail.com> wrote: > > +1 for allowing trailing comma in every function call. > > > Regards, > Kubo2 > > > 2015-06-18 19:16 GMT+02:00 Florian Anderiasch <ml@anderiasch.de>: >> On 18.06.2015 08:25, Yasuo Ohgaki wrote: >>>> If people still consider it more harm- than useful then please don't flame >>>> me and I'll shut up again :-) >>>> >>> >>> PHP allows >>> >>> array( >>> 1, >>> 2, >>> 3, >>> ); >>> >>> therefore >>> >>> my_variadic_function( >>> "foo", >>> "bar", >>> "qux", >>> ); >>> >>> is consistent behavior to me. >> >> If variadic functions allow this and normal functions don't (and by most >> PHP coding standards you'll format like this all the time because of 80 >> chars limit I don't see how this is in any way consistent. It's still a >> function call after all and not an array. >> >> ~Florian >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >