RE: [PHP-DEV] [PATCH] SNMP value retrieval

HI, Jonny, it your personal email address is bouncing. That you know (maybe even the mailinglist email bounces for you). I have looked at your patch and tested it. Seem OK. some questions and changes I would like you feedback on below. On Tuesday, January 14, 2003, at 08:19 PM, Johann Hanne wrote:

Hi, as promised I've created a patch which adds some functionality to the SNMP module. It's controlled with a new function named snmp_set_valuemethod(int method) which changes the way how SNMP values are returned by snmpget(), snmpwalk() and snmpwalkoid(). The following (new) constants can be passed to snmp_set_valuemethod(): - SNMP_VALUEMETHOD_LIBRARY: - SNMP_VALUEMETHOD_PLAIN: - SNMP_VALUEMETHOD_OBJECT:

Do these names to be so long?? I was thinking we cane drop the 'VALUEMETHOD' or 'METHOD' part. Would that be OK and which do you prefer??

the value type returned by the SNMP agent (the ASN_* constants from the net-snmp library are also defined as PHP constants)

I believe the ASN_ prefix should be SNMP_ and changed as such. That they are internally ASN_ does not matter. ANother thing I would like to ask is whether the group wants to support also all kinds of types of SNMP that are not standardized and somehow added to NET-SNMP as an expiriment. I believe it is better to drop those, what do you think?? Harrie Harrie