Re: Re: LDAP build broken

On 2015-07-06 10:36, Andreas Heigl wrote:

Am 06.07.15 um 10:15 schrieb Côme BERNIGAUD:

Possibilities are: - Add a test in the configure for this method and disable if it’s not there, tell Mac users to get a real openldap.

That might be the best solution but I think it's not really practical. Even the brew-installation (currently) uses the internal LDAP-library.

I agree this would be ideal but seems kind of harsh for Mac users

- Add the same kind of test but set a define with it and add ifdefs in the code to use ldap_find_control instead - Add the same test but in the ifdef declare an ldap_control_find method which calls ldap_find_control.

This sounds like the best solution to it. At least as long as the two functions are interchangeable. From a first glance at the code I've seen that the function-signature is different of the both, but I don't know whether that can be overcome. Going this way would mean that the code change is concentrated on one place (as far as I see it) which would make it easier to maintain. Otherwise we'd have multiple ifdefs scattered arouond the source-code. Or did I missinterpret that?

Yeah, this was the idea, concentrating the changes in one place. I’m gonna check if it’s easy to implement.

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc