Re: Reclassify E_STRICT notices

On Sun, Feb 22, 2015 at 11:30 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: > Hi internals! > > I would like to propose reclassifying our few existing E_STRICT notices and > removing this error category: > > https://wiki.php.net/rfc/reclassify_e_strict > > As we don't really have good guidelines on when which type of error should > be thrown, I'm mainly going by what category other similar errors use. I'm > open to suggestions, but hope this will not deteriorate into total > bikeshed. > > Thanks, > Nikita > hi, this RFC got accepted, but there are 4 more E_STRICTs in the core which were kept/missed: http://lxr.php.net/xref/PHP_TRUNK/ext/date/php_date.c#1544 http://lxr.php.net/xref/PHP_TRUNK/ext/standard/html.c#1241 http://lxr.php.net/xref/PHP_TRUNK/ext/mysqli/mysqli_api.c#1606 http://lxr.php.net/xref/PHP_TRUNK/ext/mysqli/mysqli_api.c#1644 for the sake of consistency I would like these to be removed/changed into some other error levels so that we emit no E_STRICT from the core. I cc'ed Andrey and Derick to this mail as I'm curious about their opinion on the mysql and date related ones. -- Ferenc Kovács @Tyr43l - http://tyrael.hu