Re: Core functions throwing exceptions in PHP7

2015-07-31 9:29 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>: > Hi Scott, > > On Fri, Jul 31, 2015 at 6:33 AM, Scott Arciszewski <scott@paragonie.com> > wrote: > >> On Jul 30, 2015 2:27 PM, "Niklas Keller" <me@kelunik.com> wrote: >> > I prefer Exception, too, because it's I/O related. >> > >> > @Scott: You can open votes on everything, doesn't matter, just create a >> page with a vote. >> > I just don't know where to put it in the wiki, because it's not a RFC. >> > >> > Regards, Niklas >> >> I'm not sure how to do that. >> >> I have a noncritical security patch I intend to write for random_bytes() >> that I would like to submit as a PR but first I'd like to see what the >> resolution will be re: Exceptions. >> >> Also, merge conflicts aren't fun. ;) >> >> If there's anything I can do to get those two merged faster, please let me >> know. > > > You can have RFC vote options like > > - Raise Error/Exception when CSPRNG is not available > (Choice: Yes/No) > - Use error(E_RECOVERABLE_ERROR) or exception(Whatever exception > prefered) > (Choice: Error/Exception) > > BTW, I prefer exception, but consistency is important also. > My vote will be Yes and Error. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > > Hi Yasuo, I think the question is more whether Exception or Error (class, not E_RECOVERABLE_ERROR), to allow handling it gracefully. Regards, Niklas