Re: com php-src: avoid unnecessary scoping: main/php_variables.c
| From: | Matt Wilmas | Date: | Sun, 02 Aug 2015 16:35:45 +0000 |
| Subject: | Re: com php-src: avoid unnecessary scoping: main/php_variables.c | ||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-87518@lists.php.net to get a copy of this message | ||
Hi Anatol,
----- Original Message -----
From: "Anatol Belski"
Sent: Friday, July 31, 2015
Commit: 3a66a23679487f4feda699ada109ab2b675e9474 Author: Anatol Belski <ab@php.net> Fri, 31 Jul 2015 14:02:03 +0200Parents: 7be9e69eafdb1828d09daecde5cd39112db3f581 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=3a66a23679487f4feda699ada109ab2b675e9474 Log: avoid unnecessary scoping Changed paths: M main/php_variables.c Diff: diff --git a/main/php_variables.c b/main/php_variables.c index ebc060b..173d6b0 100644 --- a/main/php_variables.c +++ b/main/php_variables.c [...] + /* store request init time */ + ZVAL_DOUBLE(&request_time_float, sapi_get_request_time()); + php_register_variable_ex("REQUEST_TIME_FLOAT", &request_time_float, &PG(http_globals)[TRACK_VARS_SERVER]); + ZVAL_LONG(&request_time_long, zend_dval_to_lval(Z_DVAL(request_time_float))); + php_register_variable_ex("REQUEST_TIME", &request_time_long, &PG(http_globals)[TRACK_VARS_SERVER]); } /* }}} */ While you're at it, that instance of zend_dval_to_lval() should be removed. Looks like it was wrongly added in the first place, when it's useless to have anything but a plain cast there. :-) - Matt