Re: Re: com php-src: Remove assumption that extensions are in ext/ext-name Fixesalso a weird ln (symlink) hack for phpdbg: acinclude.m4
build/config-stubsbuild/genif.sh build/order_by_dep.awk configure.in sapi/phpdbg/config.m=3
| From: | Pierre Joye | Date: | Sun, 23 Aug 2015 11:29:16 +0000 |
| Subject: | Re: Re: com php-src: Remove assumption that extensions are in ext/ext-name Fixesalso a weird ln (symlink) hack for phpdbg: acinclude.m4 build/config-stubsbuild/genif.sh build/order_by_dep.awk configure.in sapi/phpdbg/config.m=3 |
||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-87875@lists.php.net to get a copy of this message | ||
Hi,
On Aug 23, 2015 12:24 PM, "Stanislav Malyshev" <smalyshev@gmail.com> wrote:
>
> Hi!
>
> > Same problem on Travis, e.g.
> > <https://travis-ci.org/php/php-src/jobs/76612894>.
> >
> > Could you please have a look at this issue?
>
> If the problem shows on Travis, how come it got committed to master? I
> would like to call everybody with commit rights - before you push it,
> please test on Travis in your private branch! It's not hard to set up
> (e.g. see here: http://docs.travis-ci.com/user/for-beginners/),
> and it
> saves many people cleanup time. Please let's do that. If somebody has a
> problem setting it up, please ask for help on IRC or the list.
That makes me think about what we discussed a while back.
At least for stable/RC, do force to use PR and tracis check before commit.
I also like gerrit, but may be a too slow process for us.
Cheers,
Pierre