Re: Overflow checks and integral vars comparison

Hi Anatol, On Tue, Aug 25, 2015 at 12:41 PM, Anatol Belski <anatol.php@belski.net> wrote: > Hi Dmitry, > > > -----Original Message----- > > From: Dmitry Stogov [mailto:dmitry@zend.com] > > Sent: Tuesday, August 25, 2015 9:29 AM > > To: Anatol Belski <anatol.php@belski.net> > > Cc: Rowan Collins <rowan.collins@gmail.com>; PHP Internals > > <internals@lists.php.net> > > Subject: Re: [PHP-DEV] Overflow checks and integral vars comparison > > > > Hi Anatol, > > > > I don't see any problem adding ZEND_LONG_INT_OVF and similar macros into > > 7.0. > > > Thanks for taking a look. I was doing a quick RFC draft yesterday also > including a ZPP suggestion from Jakub. But given there's some demand on > such checks still, probably better I withdraw the RFC and work towards > macros for the range checks and integrating them at the appropriate places. > Pure internal stuff anyway. > > I think it makes sense to merge all macros without RFC to master for 7.0 and keep RFC just for ZPP changes as there might be some discussion about the names (e.g. "r" is already used for resources ;) ). Or maybe just check if everyone is ok with names (ZPP flags) and then integrate it as well. In any case, it would be nice to have this in ZPP at some point. Cheers Jakub