Re: com php-src: fix typo: Zend/zend_range_check.h
| From: | Matt Wilmas | Date: | Wed, 26 Aug 2015 15:22:22 +0000 |
| Subject: | Re: com php-src: fix typo: Zend/zend_range_check.h | ||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-87934@lists.php.net to get a copy of this message | ||
Hi Anatol :-),
Just wanted to point out that those conditions (non-0 macros, of course) should use UNEXPECTED(), so their code block can be moved "out of the way." (May already be happening with a "return" involved.)
Although now, IF php_error_docref is involved, that *should* implicitly happen since it has been marked with ZEND_COLD. Still, better to explicitly use UNEXPECTED(), which covers all cases...
- Matt
----- Original Message -----
From: "Anatol Belski"
Sent: Wednesday, August 26, 2015
Commit: d40a149ade589cdb97604ceb22560214ff3870bd Author: Anatol Belski <ab@php.net> Tue, 25 Aug 2015 15:30:57 +0200Parents: c867b510df2a2f746ae2ec60116b5b4f463abd83 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d40a149ade589cdb97604ceb22560214ff3870bd Log: fix typo Changed paths: M Zend/zend_range_check.h Diff: diff --git a/Zend/zend_range_check.h b/Zend/zend_range_check.h index 7c13332..f47b652 100644 --- a/Zend/zend_range_check.h +++ b/Zend/zend_range_check.h @@ -24,7 +24,7 @@ /* Flag macros for basic range recognition. Notable is that always sizeof(signed) == sizeof(unsigned), so no need to overcomplicate things. */ -#if SIZEOF_INT == SIZEOF_ZEND_LONG +#if SIZEOF_INT < SIZEOF_ZEND_LONG # define ZEND_LONG_CAN_OVFL_INT 1 # define ZEND_LONG_CAN_OVFL_UINT 1 #endif