RE: [PHP-DEV] Disable SAPI based HANDLE_BLOCK_INTERRUPTIONS()

Hi Dmitry, > -----Original Message----- > From: Dmitry Stogov [mailto:dmitry@zend.com] > Sent: Friday, August 28, 2015 3:24 PM > To: Rasmus Lerdorf <rasmus@lerdorf.com>; Ilia Alshanetsky <iliaa@php.net>; > Zeev Suraski <zeev@zend.com>; PHP Internals <internals@lists.php.net> > Cc: Anatol Belski <ab@php.net>; Nikita Popov <nikita.ppv@gmail.com>; Xinchen > Hui <xinchen.h@zend.com> > Subject: [PHP-DEV] Disable SAPI based HANDLE_BLOCK_INTERRUPTIONS() > > Hi, > > I've disabled SAPI based signal protection. > It was used only by Apache1 SAPI, but PHP7 doesn't support it anyway. > So, we had to perform useless checks on each zend_hash_add(). > > Please take a look, and tell me if you see possible problems. > > I think, it makes sense to completely remove corresponding API in zend.h and > SAPI.h. > It doesn't look like zend_utility_functions struct was ever used outside the core, so ABI compat is not really a concern. Given no SAPI would inject these hooks anymore (and that was actually Apache only that did it), IMHO it is fine to remove the corresponding parts. Regards Anatol