Re: json_decode/encode should return full precision values by default
| From: | Yasuo Ohgaki | Date: | Tue, 01 Sep 2015 02:07:47 +0000 |
| Subject: | Re: json_decode/encode should return full precision values by default | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-87968@lists.php.net to get a copy of this message | ||
Hi all,
Sorry, I was a bit busy during August.
On Wed, Aug 5, 2015 at 5:37 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> I sent work in progress PR for this and updated the RFC.
>
> https://github.com/php/php-src/pull/1455
> TODO: Add/modify tests. Add 0 mode support for PG(precision). Add
> WDDX/XMLRPC PG(serialize_precision) support.
>
> https://wiki.php.net/rfc/precise_float_value
The patch and wiki is updated.
It's better to minimize the change at this time.
I didn't look into WDDX/XMLRPC which uses EG(precision), if anyone
insist, I'll look into it.
I don't mind much if anyone suggests to drop PHP 5.6 part. I'll drop the
part before RFC discussion to focus PHP7.
It should only affects php_gcvt() and php.ini's precision setting.
i.e. var_dump/var_export/
json_encode/echo/print. Tests passes, but if anyone notice
misbehavior, please let me
know.
I would like to start RFC discussion in a few days.
Thank you.
--
Yasuo Ohgaki
yohgaki@ohgaki.net